Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

helm_wrapper does a verbose rm for cleanup interfering with templating #126

Open
ilionblaze opened this issue Jul 5, 2019 · 1 comment

Comments

@ilionblaze
Copy link

Due to the verbose flag in the cleanup code for helm_wrapper, decrypted filenames are output:

    # cleanup on-the-fly decrypted files
    [[ ${#decfiles[@]} -gt 0 ]] && rm -v "${decfiles[@]}"

This means you can't run helm secrets template -f values.yaml -f secrets.yaml ./ > template.yaml without having to edit the file.

Removing the -v would fix this, or adding a new flag to run a silent cleanup. I suspect the goal is to avoid new flags which may interfere with helm compatibility?

@kavirajk
Copy link

kavirajk commented Aug 6, 2019

+1

really block from using tools like Tilt (tilt.dev). Where we generate k8 specs via helm-template.

jimeh added a commit to jimeh/helm-secrets that referenced this issue Sep 23, 2019
For all wrapped Helm commands the list of decrypted files is printed as
they get removed at the end of plugin execution. For the `template`
command this is undesired, as it means you cannot simply run `helm
secrets template` and get valid YAML output.

This change suppresses the output of deleted files for the `template`
only, meaning it does not alter the behavior of other commands, but just
fixes the `template` command to work as I imagine most people would
expect it to work.

[Fixes issues zendesk#126 and zendesk#132]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants