Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Russian translation #104

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

leokostarev
Copy link

fixes #103

This pull request addresses numerous mistakes in Russian translation.

Copy link

@Smooth-E Smooth-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Found some inconsistencies in letter casing and formulations. The Zen Mods section probably needs another go, GitHub did not allow to make reviews on unchanged code.

A couple of comments are in Russian, they do not contain any useful info for non Russian-speaking maintainers.

Comment on lines 7 to 12
.label = Add to Essentials
.label = Добавить в необходимые
.accesskey = E
tab-context-zen-remove-essential =
.label = Remove from Essentials
.label = Удалить из необходимых
.accesskey = R

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a better word for the "Essentials". First of all, we should capitalize the word as it is the name of the feature and not just "some collection of essential things". How about Добавить в Необходимое, as in "Add to Vault" and not "Add to secure things", if we take some kind of vault as a similar example?

Comment on lines 4 to 5
[1] Разделенная Вкладка (требуется несколько выделенных вкладок)
*[other] Разделить { $tabCount } Вкладок

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for other strings, we do not capitalize common nouns and words in general throughout the sentence."Tab" seems to be a common word, unlike "Essentials" which I mentioned earlier. Here is what I suggest:

Suggested change
[1] Разделенная Вкладка (требуется несколько выделенных вкладок)
*[other] Разделить { $tabCount } Вкладок
[1] Разделенная вкладка (требуется несколько выделенных вкладок)
*[other] Разделить { $tabCount } вкладок

.accesskey = У
zen-web-side-panel-context-enable-ua =
.label = Включить мобильный UserAgent
.label = Включить режим мобильного

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.label = Включить режим мобильного
.label = Включить мобильный режим

@@ -20,10 +22,12 @@ zen-web-side-panel-open-in-new-tab =
.label = Открыть в новой вкладке
.accesskey = Н
zen-web-side-panel-context-open-in-container-tab =
.label = Открыть в вкладке Контейнер
.label = Открыть в вкладке Контейнере

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Containers are some sort of groups or similar qualities for tabs. I think this formulation suits the feature better. Example of similar tense: "Обратиться в офис в строении".

Suggested change
.label = Открыть в вкладке Контейнере
.label = Открыть во вкладке в Контейнере

welcome-dialog-get-started = Начать работу

welcome-dialog-import = 😍 Добавьте избранное { -brand-short-name }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original wording is "Add your favorites to {Zen}". Though I agree that we can omit the your.

Suggested change
welcome-dialog-import = 😍 Добавьте избранное { -brand-short-name }
welcome-dialog-import = 😍 Перенесите избранное в { -brand-short-name }

zen-settings-CKS-reset-shortcuts =
.label = Сброс по умолчанию

zenCKSOption-group-other = Прочие вопросы

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zenCKSOption-group-other = Прочие вопросы
zenCKSOption-group-other = Прочее

zen-picture-in-picture-toggle-shortcut-mac-alt = Переключить изображение в картинке (Mac Alt)
zen-picture-in-picture-toggle-shortcut-alt = Переключить режим "картинка в картинке" (Alt)
zen-picture-in-picture-toggle-shortcut-mac = Переключить режим "картинка в картинке" (Mac)
zen-picture-in-picture-toggle-shortcut-mac-alt = Переключить режим "картинка в картинке" (Mac Alt)
zen-page-source-shortcut-safari = Просмотр исходного кода страницы (Safari)
zen-nav-stop-shortcut = Остановить загрузку
zen-history-sidebar-shortcut = Show History Sidebar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zen-history-sidebar-shortcut = Show History Sidebar
zen-history-sidebar-shortcut = Показать Историю

@@ -239,7 +278,7 @@ zen-bookmark-show-library-shortcut = Показать библиотеку за
zen-key-stop = Остановить загрузку
zen-full-zoom-reduce-shortcut = Уменьшить
zen-full-zoom-enlarge-shortcut = Увеличить
zen-full-zoom-reset-shortcut = Reset Zoom
zen-full-zoom-reset-shortcut = Сбросить увеличение

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zen-full-zoom-reset-shortcut = Сбросить увеличение
zen-full-zoom-reset-shortcut = Сбросить масштабирование

@@ -248,39 +287,39 @@ zen-quit-app-shortcut = Выйти из приложения
zen-key-wr-capture-cmd = Команда захвата WR
zen-key-wr-toggle-capture-sequence-cmd = Переключить последовательность захвата WR
zen-nav-reload-shortcut = Обновить страницу
zen-nav-reload-shortcut-skip-cache = Reload Page (Skip Cache)
zen-nav-reload-shortcut-skip-cache = Обновить страницу (Без кэша)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zen-nav-reload-shortcut-skip-cache = Обновить страницу (Без кэша)
zen-nav-reload-shortcut-skip-cache = Обновить страницу (с очисткой кеша)

Comment on lines 296 to 307
zen-workspace-shortcut-switch-1 = Переключиться в пространство 1
zen-workspace-shortcut-switch-2 = Переключиться в пространство 2
zen-workspace-shortcut-switch-3 = Переключиться в пространство 3
zen-workspace-shortcut-switch-4 = Переключиться в пространство 4
zen-workspace-shortcut-switch-5 = Переключиться в пространство 5
zen-workspace-shortcut-switch-6 = Переключиться в пространство 6
zen-workspace-shortcut-switch-7 = Переключиться в пространство 7
zen-workspace-shortcut-switch-8 = Переключиться в пространство 8
zen-workspace-shortcut-switch-9 = Переключиться в пространство 9
zen-workspace-shortcut-switch-10 = Переключиться в пространство 10
zen-workspace-shortcut-forward = Следующее пространство
zen-workspace-shortcut-backward = Предыдущее пространство

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zen-workspace-shortcut-switch-1 = Переключиться в пространство 1
zen-workspace-shortcut-switch-2 = Переключиться в пространство 2
zen-workspace-shortcut-switch-3 = Переключиться в пространство 3
zen-workspace-shortcut-switch-4 = Переключиться в пространство 4
zen-workspace-shortcut-switch-5 = Переключиться в пространство 5
zen-workspace-shortcut-switch-6 = Переключиться в пространство 6
zen-workspace-shortcut-switch-7 = Переключиться в пространство 7
zen-workspace-shortcut-switch-8 = Переключиться в пространство 8
zen-workspace-shortcut-switch-9 = Переключиться в пространство 9
zen-workspace-shortcut-switch-10 = Переключиться в пространство 10
zen-workspace-shortcut-forward = Следующее пространство
zen-workspace-shortcut-backward = Предыдущее пространство
zen-workspace-shortcut-switch-1 = Переключиться в Пространство 1
zen-workspace-shortcut-switch-2 = Переключиться в Пространство 2
zen-workspace-shortcut-switch-3 = Переключиться в Пространство 3
zen-workspace-shortcut-switch-4 = Переключиться в Пространство 4
zen-workspace-shortcut-switch-5 = Переключиться в Пространство 5
zen-workspace-shortcut-switch-6 = Переключиться в Пространство 6
zen-workspace-shortcut-switch-7 = Переключиться в Пространство 7
zen-workspace-shortcut-switch-8 = Переключиться в Пространство 8
zen-workspace-shortcut-switch-9 = Переключиться в Пространство 9
zen-workspace-shortcut-switch-10 = Переключиться в Пространство 10
zen-workspace-shortcut-forward = Следующее Пространство
zen-workspace-shortcut-backward = Предыдущее Пространство

@leokostarev
Copy link
Author

@Smooth-E
Thank you for corrections! I applied them.

I agree, that some words should not be capitalized. But if you look at en-US translation, it is done different. For example all drop-downs are fully capitalized.
I am not familiar with translation, are different text cases inherent to cultures, or is it just lack of consistency?

@leokostarev leokostarev requested a review from Smooth-E November 16, 2024 16:25
@Smooth-E
Copy link

@Smooth-E Thank you for corrections! I applied them.

I agree, that some words should not be capitalized. But if you look at en-US translation, it is done different. For example all drop-downs are fully capitalized. I am not familiar with translation, are different text cases inherent to cultures, or is it just lack of consistency?

Good. I will conduct another review a bit later.

Regarding the letter casing, there is no strict rule as far as I am aware, but generally in Russian we do capital letter at the start of the string and small letters for the rest of the words. Here are some examples:

Thunderbird Desktop

English Russian
Help menu in English Help menu in Russian

Microsoft Word (notice the "Add Comment" and "Read Aloud" entries)

English Russian
Right-click menu in English Right-click menu in Russian

Copy link

@Smooth-E Smooth-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Found a couple of typos and places where discussion on what wording to chose is needed. Also, I just thought of that accessibility keys should be changed after we settle the final strings, because it looks better when those keys are letter from the strings themselves.

zen-look-and-feel-use-workspace-colors =
.label = Использовать цвета рабочей области как основной цвет
.label = Использовать цвета текущего Пространства как основной цвет

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.label = Использовать цвета текущего Пространства как основной цвет
.label = Использовать цвета текущего Пространства как основные

zen-glance-enabled =
.label = Включить Взгляд
.label = Включить Предпросмотр

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say this looks good

.label = Показать на короткое время всплывающее окно панели инструментов при переключении или открытии новых вкладок в компактном режиме

zen-look-and-feel-buttons-header = Стиль кнопок
zen-look-and-feel-buttons-description = Выберите предпочтительный стиль кнопок

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is difficult for me. Don't we use "предпочитаемый" more? Although, to which I was surprised, there is no examples of use and a proper meaning definition on Wiktionary.

Suggested change
zen-look-and-feel-buttons-description = Выберите предпочтительный стиль кнопок
zen-look-and-feel-buttons-description = Выберите предпочитаемый стиль кнопок

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also just omit the word all together. Though, this will make a description string look kind of too short.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thing "предпочитаемый" is tiniest bit less formal then "предпочтительный", also reads nicer.

zen-vertical-tabs-newtab-top-button-border =
.label = Show separation border for when the new tab button is at the bottom
.label = Показывать линию-разделитель, когда кнокпа "Новая вкладка" находится внизу

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo on my side, I suppose.

Suggested change
.label = Показывать линию-разделитель, когда кнокпа "Новая вкладка" находится внизу
.label = Показывать линию-разделитель, когда кнопка "Новая вкладка" находится внизу

zen-settings-workspaces-display-as-icon-strip =
.label = Показать рабочие области как значок полосы
.label = Показать Пространства как полосу иконок

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a better wording

Suggested change
.label = Показать Пространства как полосу иконок
.label = Показывать Пространства как полосу иконок

zen-theme-marketplace-link = Посетить магазин
zen-dark-theme-styles-header = Тёмные стили темы

zen-dark-theme-styles-header = Стили темной темы
zen-dark-theme-styles-description = Настроить темную тему по своему вкусу

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
zen-dark-theme-styles-description = Настроить темную тему по своему вкусу
zen-dark-theme-styles-description = Настройте темную тему по своему вкусу

@@ -1,15 +1,17 @@
zen-web-side-panel-context-mute-panel =
.label = Отключить веб-панель
.label = Заглушить веб-панель

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have "Включить звук веб-панели", how about this:

Suggested change
.label = Заглушить веб-панель
.label = Отключить звук веб-панели

zen-web-side-panel-context-add-to-panel =
.label = Добавить в веб-панели
.accesskey = А

zen-sidebar-introduction-title = Добро пожаловать в боковую панель Zen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it consistent between the header and the description.

Suggested change
zen-sidebar-introduction-title = Добро пожаловать в боковую панель Zen
zen-sidebar-introduction-title = Добро пожаловать в Zen Sidebar

Or we can say "Zen Sidebar" in the header to introduce a cool brand-feature name and then say "боковая панель" in the description to build the connection between these terms. Additionally, I don't think "Боковая панель Zen" would look good for a hero text, as it is too long of a string

welcome-dialog-back-action = Назад
welcome-dialog-next-action = Следующий
welcome-dialog-next-action = Далее

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline 😜

Suggested change
welcome-dialog-next-action = Далее
welcome-dialog-next-action = Далее

welcome-dialog-theme-subtext = Персонализируйте ваш опыт с вашим любимым видом!

welcome-dialog-theme = Чувствуйте себя как дома
welcome-dialog-theme-subtext = Настройте облик браузера, как вам нравится!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought of wouldn't it be nicer if we use a sentence for this that is less generic and more common in Russian? Something like this:

Suggested change
welcome-dialog-theme-subtext = Настройте облик браузера, как вам нравится!
welcome-dialog-theme-subtext = Сделайте { -brand-short-name } по-настоящему вашим!

Though I should ask @mauro-balades of whether it is okay to include { -brand-short-name } here.

@leokostarev
Copy link
Author

Thanks! Applied those.

@leokostarev
Copy link
Author

leokostarev commented Nov 18, 2024

@Smooth-E
Perhaps accessibility keys should be in different PR.
Will you be checking further? If this looks good to you I'll ping mauro-balades.

@leokostarev leokostarev requested a review from Smooth-E November 18, 2024 14:40
@Smooth-E
Copy link

Sure, I will review another time in 5-10 hours. Will mark as approved if everything is fine

Copy link

@Smooth-E Smooth-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor improvements and things I missed in previous reviews

ru/browser/browser/preferences/zen-preferences.ftl Outdated Show resolved Hide resolved
ru/browser/browser/zen-split-view.ftl Outdated Show resolved Hide resolved
ru/browser/browser/zen-welcome.ftl Outdated Show resolved Hide resolved
ru/browser/browser/zenAppExtensionFields.ftl Outdated Show resolved Hide resolved
ru/browser/browser/zenAppExtensionFields.ftl Outdated Show resolved Hide resolved
@leokostarev leokostarev requested a review from Smooth-E November 19, 2024 08:03
Copy link

@Smooth-E Smooth-E left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gotta pay a bit more attention to typos before I submit a review. Fix this and we are good to go!

ru/browser/browser/zenAppExtensionFields.ftl Outdated Show resolved Hide resolved
Co-authored-by: Smooth E <[email protected]>
@leokostarev
Copy link
Author

@Smooth-E
Thanks for corrections!

@mauro-balades
This PR is ready! Please take a look at it.

@Anoms12
Copy link

Anoms12 commented Nov 28, 2024

@mr-cheff may we get this pushed for him?

@leokostarev
Copy link
Author

@Anoms12 is there hope for this PR?

@Anoms12
Copy link

Anoms12 commented Dec 6, 2024

Don't know, not a dev, just a fan :\

@Smooth-E
Copy link

Smooth-E commented Dec 8, 2024

@leokostarev I am afraid we skipped an important point. There is a link at the end of the readme called "Contribute". On the page they explain that this project is translated through Crowdin. One of us should simply bring the strings from this pull request to Crowdin. I am currently busy, so let me know if you decide to do this and I will let you know if I will.

@leokostarev
Copy link
Author

@Smooth-E yeah, it unfortunate, I will let you know, if I will have free time to do this

@mr-cheff
Copy link
Member

Is this ready to merge?

@Smooth-E
Copy link

Is this ready to merge?

Yes. I just did not start another review to mark them as approved, but they are good to go

@leokostarev
Copy link
Author

@mr-cheff I resolved merge conflict, It is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect/missing Russian translation
4 participants