Document & test the semantics of GetRawTransaction, and fix platform-dependent parsing.
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
changed the title
getrawtransaction results.GetRawTransaction, and fix platform-dependent parsing.
str4d
requested changes
Aug 13, 2024
frontend/service.go
Outdated
| // the meanings of the `Height` field of the `RawTransaction` type are as | ||
| // follows: | ||
| // | ||
| // * height 0: the transaction is in the mempool |
There was a problem hiding this comment.
This aliases with the genesis block height, but is safe solely because the mainnet Zcash genesis block only contained a single transaction (the coinbase) which had no outputs (due to slow start), so no wallet will ever be interested in it even if they incorrectly observe it as "in the mempool".
…RawTransaction` This also modifies the internal `common.ZcashdRpcReplyGetrawtransaction` type to ensure that the reinterpretation of the `-1` height value from a `getrawtransaction` response is not platform-dependent.
nuttycom
force-pushed
the
getrawtransaction_parse_testing
branch
from
b5f3f63 to
56fe52a
Compare
str4d
approved these changes
Aug 13, 2024
13 tasks
str4d
approved these changes
Aug 13, 2024
AArnott
reviewed
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure this checklist is followed for any pull requests for this repo. This checklist must be checked by both the PR creator and by anyone who reviews the PR.
As a note, all CI tests need to be passing and all appropriate code reviews need to be done before this PR can be merged
Fixes #493