fix: make root directory detection dynamic #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Instead of calling
vim.loop.cwd()
when the plugin is initialized, this pull request calls whatever function is stored in the config asget_root
every time the LSP attaches to a buffer. I've set this torequire("lspconfig.util").find_git_ancestor
by default, which seems like a reasonable default.I guess we might need to update the installation instructions, since we now depend on
lspconfig
, or perhaps it would be better just to set a different default (vim.loop.cwd()
, but called every time the server is updated, maybe).