-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current Goals #14
Comments
Hi Zack,
Something like https://github.com/tzachar/cmp-tabnine#setup would be nice |
Hi @sbulav, thank you for the input, just a couple of comments:
I'm not certain of what you mean by this. The server itself is a rpc, so neovim just sends out the command to start it. If you want to have it start automatically rather than InsertEnter, and still not affect startup time, using
This is a great idea and something that should be released soon.
I'm not sure what you mean by this. If here, you mean ask for completions of a certain length, that's not supported by copilot to my knowledge. The copilot discussion forum has also been complaining over the last couple days about general copilot performance regarding its ability to generate full functions/only getting one line, so it's not just the plugins I wrote... We are somewhat at the mercy of copilot's api here. I did some testing for zbirenbaum/copilot-cmp#5 and it turns out that while I can force a request for completions in such cases, the server returns no results. I have requested an openai codex key, and whenever I get off that waitlist, I'll use it to make my own minimal lsp for completions. This should be able to support more fine grained things like how much of a completion you want, but I can't promise anything, and even once I do have one, you would need a codex key to run it. |
Specifying on which filetypes to start the plugin Checks have been written in to make sure copilot doesn't start in buffers like Somehow I got my codex key literally today an hour after I responded to you. If you don't have one, I would apply to their waitlist now, so that whenever I have the time to make a much more specialized plugin and api than is possible with copilot you will be able to use it. |
Hi @zbirenbaum As for the line length, I mean that sometimes completion, provided by the copilot, gets ridiculously long. Check out this example: I'd like to have an option to limit line length to, let's say, 80 symbols. |
Glad to hear the lag issue is fixed! I noticed that too, but I have cmp's max len limited so it never got that bad lol. I pushed an update to copilot-cmp just now, which caps it at 30 chars or abbreviates it with the first 20 + '...' + last 10 for the label. I'd like the user to be able to customize it, but integrating setup options has been an ongoing debate with myself regarding how to design them best. For now, I hope the change helps. I know you said 80, but since there's a preview in the doc window, and more than 30 + the ' ... ' was making my screen cluttered with a vertical split I thought it would be a rational default for most people to cap it there. I'll definitely make that one of the first customizable options once I figure out how I want to do the user params. It gets really complicated because I want to have the option to make custom options for getting the completions, like having copilot.lua request them every 200ms in a loop and read from there, but to my knowledge most cmp sources haven't been so ambitious in customizability, and the codebase is rather difficult. I don't want to have a bunch of breaking changes trying to get it done and life is a bit busy right now to even attempt it anyways, but it'll be something to look forward to in the coming weeks once I have a little more time to dedicate to it. I know that was probably waaay more info than you asked for or even wanted, but I thought giving a general status update here for anyone interested was probably in order. |
edit: sorry posted in the wrong thread |
Thank you for great work you did with the plugins. Here are a couple of things that would be good to have:
|
@dklymenk |
Closing this, since everything's pretty much working as expected right now and all the goals are met already. |
Now that I believe I have the copilot plugins in a stable state, here are the goals I have planned for the future:
???: Provide your input! What else would you like to see? Please feel free to comment and discuss here, or create an issue with the enhancement/feature flags.
The text was updated successfully, but these errors were encountered: