Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the compressor type right? #94

Open
jbusecke opened this issue Apr 25, 2024 · 1 comment
Open

Is the compressor type right? #94

jbusecke opened this issue Apr 25, 2024 · 1 comment
Labels
zarr-python Relevant to zarr-python upstream

Comments

@jbusecke
Copy link
Contributor

jbusecke commented Apr 25, 2024

As part of #93 I just ran into an issue with the type of filters on zarr.Codec and zarr.Zarray which I then noticed was already fixed on main by #66.

I was wondering though if the type of compressor also needs to be changed from str to Codec as indicated in the zarr API docs?

image
@TomNicholas TomNicholas added the zarr-python Relevant to zarr-python upstream label Apr 25, 2024
@TomNicholas
Copy link
Collaborator

I think this is zarr v2 vs v3 difference. In v2 there were separate filters and compressors, but in v3 those are both examples of codecs. Internally VirtualiZarr currently uses the word "codec" to refer to things that must be the same between arrays in order for them to be concatenatable, so the Codec class I defined in virtualizarr/zarr.py is just a way to keep the filter and compressor together.

Ideally all these differences would be handled by a compatibility class that I just import from zarr-python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zarr-python Relevant to zarr-python upstream
Projects
None yet
Development

No branches or pull requests

2 participants