Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cloudpathlib instead of fsspec? #172

Open
TomNicholas opened this issue Jul 1, 2024 · 5 comments
Open

Use cloudpathlib instead of fsspec? #172

TomNicholas opened this issue Jul 1, 2024 · 5 comments
Labels
remote files Reading references from non-local files

Comments

@TomNicholas
Copy link
Collaborator

AFAIK the only filesystems we need to read from are local and cloud, so could we just use pathlib and cloudpathlib?

@TomNicholas
Copy link
Collaborator Author

In particular we could just call cloudpathlib.AnyPath

https://cloudpathlib.drivendata.org/stable/anypath-polymorphism/

@norlandrhagen
Copy link
Collaborator

This would be really cool @TomNicholas!

Seems like it can read over s3 into xarray:

from cloudpathlib import CloudPath
import xarray as xr 
cloudpath = CloudPath("s3://carbonplan-share/air_temp.nc")
ds = xr.open_dataset(cloudpath)

@norlandrhagen
Copy link
Collaborator

A little more exploration. It looks like SingleHDFToZarr works both for s3 and local.

from kerchunk.hdf import SingleHdf5ToZarr
import io 
from cloudpathlib import CloudPath
import xarray as xr 
# from cloudpathlib import AnyPath

cloudpath = CloudPath("s3://carbonplan-share/air_temp.nc")

with open(cloudpath, 'rb') as f:
  contents = f.read()
  refs = SingleHdf5ToZarr(io.BytesIO(contents)).translate()
refs

@TomNicholas
Copy link
Collaborator Author

Some more thoughts - one way to smooth this transition would be to replace all uses of UPath (which is based on fsspec) with cloudpathlib's AnyPath. They are both very similar - for example they both implement a .stat method, which is used in https://github.com/zarr-developers/VirtualiZarr/pull/187/files#r1678802398.

The snag here is that I don't think cloudpathlib supports https...

@TomNicholas TomNicholas added the remote files Reading references from non-local files label Jul 21, 2024
@TomNicholas
Copy link
Collaborator Author

The snag here is that I don't think cloudpathlib supports https...

I raised drivendataorg/cloudpathlib#455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote files Reading references from non-local files
Projects
None yet
Development

No branches or pull requests

2 participants