Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime selection of YT video stream #670

Open
RJVB opened this issue Nov 12, 2023 · 4 comments
Open

runtime selection of YT video stream #670

RJVB opened this issue Nov 12, 2023 · 4 comments

Comments

@RJVB
Copy link
Contributor

RJVB commented Nov 12, 2023

If memory serves me well from an earlier issue, QMPlay2 now actually downloads multiple audio and video streams for YT videos that have them, and then selects the best quality pair that corresponds to the user's settings. In practice I think that's always the Opus audio that is usually served with the VP9 video.

If these streams are being downloaded anyway, wouldn't it be possible to list them in the info panel and streams menus, so that we can make runtime adjustments to our preconfigured choice?
I for instance still don't have hardware-accelerated VP9 playback, usually prefer it over H264 for the visibly better quality but I don't really need that when listening to a concert where I won't be watching the video most of the time. In that case I'd prefer to let the GPU do the work and free the CPU up for other things. Not to mention cutting down on fan noise ;)

I know I can switch the video off completely but turning it back on usually restarts playback from the beginning so I only use that feature when I'm certain I won't be wanting to watch the video at all.

@zaps166
Copy link
Owner

zaps166 commented Nov 28, 2023

I for instance still don't have hardware-accelerated VP9 playback, usually prefer it over H264 for the visibly better quality

You can use AV1 codec now 🙂

In that case I'd prefer to let the GPU do the work and free the CPU up for other things. Not to mention cutting down on fan noise ;)

Press O key (Playback->Enable video) to disable video at all - the video is not downloaded (if stream allows it - on YouTube mostly possible) also it doesn't decode - CPU (decoder) and GPU (decoder and/or display) are doing nothing with video.

@RJVB
Copy link
Contributor Author

RJVB commented Nov 29, 2023 via email

@zaps166
Copy link
Owner

zaps166 commented Nov 30, 2023

I'm aware of this issue. It's not that easy, because it doesn't download, demux, decode data, so if you enable video at any moment, it needs to buffer it first, demux and decode since nearest key-frame - it'll never be instant, but I can try to improve it a bit. Currently QMPlay2 clears all buffers if you enable video 😄

@RJVB
Copy link
Contributor Author

RJVB commented Nov 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants