Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: PR Title contains Issue number #513

Open
fragsalat opened this issue Jul 5, 2017 · 2 comments
Open

Feature: PR Title contains Issue number #513

fragsalat opened this issue Jul 5, 2017 · 2 comments

Comments

@fragsalat
Copy link

We would like to enforce our PR titles to follow the same pattern as the commits because if you make a squash merge the PR title is by default taken for the commit message which often leads to a failing commit message check which is only fixable via rebasing. A PR title would be much easier to fix.

Would you like to have such a feature and merge a PR for this?

@harti2006
Copy link
Contributor

@fragsalat Please note that the commit message check is not longer required to meet compliance requirements. Only approval + specification check. Do you in this case still need this feature?
Usually you get a proper "link" between PRs and issues, when you write "fixes #ISSUE_NUMBER" in the PR body.

@fragsalat
Copy link
Author

Yeah because we decided to go with squash merges and feature and task branches and the PR title is used for the Commit message. So when you have a PR from a task into a feature branch with a pr title which doesn't match the commig message check the PR from feature to master branch will fail. Therefore I would like to have a check for the PR title as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants