feat: obfuscate refresh_token parameter in oauth request by default #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymgendin
requested review from
whiskeysierra,
lukasniemeier-zalando,
kasmarian and
msdousti
as code owners
kasmarian
approved these changes
Nov 29, 2024
maksymgendin
force-pushed
the
feat/obfuscate-refresh_token-in-oauth-request
branch
from
f4707c6 to
7f275fc
Compare
maksymgendin
force-pushed
the
feat/obfuscate-refresh_token-in-oauth-request
branch
from
7f275fc to
dd8079d
Compare
|
Sorry, I had to force push for signing my commit. |
msdousti
approved these changes
Dec 9, 2024
|
@kasmarian Could you please approve again? |
kasmarian
approved these changes
Dec 9, 2024
|
Thank you for the PR, @maksymgendin ! |
maksymgendin
deleted the
feat/obfuscate-refresh_token-in-oauth-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For OAuth 2.0 Refresh Token Grant Type the
refresh_tokenis a required parameter and should be obfuscated by defaultorg.zalando.logbook.BodyFilter.Motivation and Context
The OAuth 2.0 Refresh Token is a sensitive token and should not be logged in plain text, same as
passwordandclient_secret.This was already discussed here but I'm not sure why this behavior was not added already at that time earlier.
Types of changes
Checklist: