Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document features #2

Open
MartinMuzatko opened this issue Oct 5, 2020 · 0 comments
Open

document features #2

MartinMuzatko opened this issue Oct 5, 2020 · 0 comments

Comments

@MartinMuzatko
Copy link

MartinMuzatko commented Oct 5, 2020

What does scalable mean for you?
For what measures? Team size? Deployment target? Testing? New features?

Right now the example is single-use-case oriented.
Are you implementing the node best practices?
Are you implementing the 12 factor app best practices?
I can keep on stuffing files in services, models and routes but it will lack essential features that I miss from a professional scalable architecture.

Is it a monolithical approach? Is it a micro-serivce oriented approach? Do you let people decide?

Just to name a few, to call this anything close to scalable, I am missing:

  • code style configuration
  • logging
  • configuration defined by environment variables
  • tests
  • dependency injection
  • freedom of data adapters (database, pubsub, authentication)
  • JSDOC, exported documentation (to put online) and generation of it (HTTP API, Schema, JS API)
  • boilerplate creation of new modules
  • services that can be reused without the express objects leaking through the entire code base
  • types

The problem with scalable is, that it does not only concern nodejs. You need to take care of the tooling around and the tooling needed to continuously package, deploy and extend the codebase and all its dependencies flawlessly.
Scalable means I am enabled to add features with confidence, not breaking something else as I add new things.

I am missing all these things from this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant