Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

story(config): implement source interface on manager #269

Closed
2 tasks
Zaba505 opened this issue Sep 15, 2024 · 0 comments · Fixed by #270
Closed
2 tasks

story(config): implement source interface on manager #269

Zaba505 opened this issue Sep 15, 2024 · 0 comments · Fixed by #270
Assignees
Labels
enhancement New feature or request

Comments

@Zaba505
Copy link
Member

Zaba505 commented Sep 15, 2024

Description

As a user, I want the config.Manager to implement the config.Source interface because I may need/want to read config.Sources before passing them to config.Read.

The scenario where this really appears is reading config.Sources before then passing them to bedrock.Run. The problem here is that config.Source is not guaranteed to be repeatable. Thus, when bedrock.Run tries to read the already read config.Sources it fails often times because the underlying io.Readers are now empty.

Acceptance Criteria

  • config.Manager should implement config.Source
  • update config.Read in case of only one config.Source and it's already a config.Manager

Related Issues

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant