Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue function not working #234

Open
Mpkch opened this issue Aug 20, 2021 · 7 comments
Open

Queue function not working #234

Mpkch opened this issue Aug 20, 2021 · 7 comments

Comments

@Mpkch
Copy link

Mpkch commented Aug 20, 2021

CPod version:
1.28.0
Platform:
Windows 10
Installation type (.deb, Snap, etc.):
CPod-Setup-1.28.0.exe

Description:
Queue function doesn't work - popup appears to say that episode is queued, but Queue remains empty

cbus-ui.js:920 Uncaught TypeError: Cannot read property 'fromUI' of undefined
    at Object.callback (cbus-ui.js:920)
    at Object.cbus.broadcast.send (cbus-broadcast.js:8)
    at Object.enqueue (cbus-audio.js:279)
    at HTMLButtonElement.elem.getElementsByClassName.onclick (cbus-ui.js:620)

(anonymous) @ cbus-ui.js:920
cbus.broadcast.send @ cbus-broadcast.js:8
enqueue @ cbus-audio.js:279
elem.getElementsByClassName.onclick @ cbus-ui.js:620

Version of CPod which introduced the issue (if applicable):

Steps to reproduce:
Select any podcast episode and click on the Add To Queue icon.
The "added 'episode name' to Queue popup appears as intended, but error above is thrown in the console.
Queue is empty

Other information (e.g. Developer Tools console log, screenshots) if possible:
@kadykov
Copy link

kadykov commented Sep 21, 2021

I have the same issue on Windows 10 x64

@leighsmith
Copy link
Contributor

The problem is the queueUpdate message is sent from both cbus-ui.js and cbus-audio.js, and is listened to by cbus-ui.js, cbus-audio.js and cbus-data.js, but only within cbus-ui.js is there a {fromUI: true} data field passed, the remainder of the .send(queueUpdate) statements do not pass a data field, which causes the error message.

@leighsmith
Copy link
Contributor

The easy fix is to simply add {fromUI: false} to all of the statements with .send("queueUpdate"), but it's not clear if indeed that fromUI should be declared as false, or true in which cases?

@leighsmith
Copy link
Contributor

OK there is a fix on my branch but it's really just a one line change.

@Desconvidado
Copy link

same issue here, im using linux appimage.

@z------------- z------------- mentioned this issue Oct 31, 2021
Merged
z------------- added a commit that referenced this issue Jan 16, 2022
@z-------------
Merge pull request #237 from leighsmith/duplicated_episodes
0f6c847 
- 	Fixed duplicated episodes on sites such as Patreon which emit changing URLs. Now uses the `<guid>` element as an id if it's present in the feed in preference to the URL.
-	Correctly retrieve episode descriptions where an empty `<itunes:description/>` element and a `<description>` element may both exist in the feed.
-	Fixed queue errors [reported](https://github.com/z-------------/CPod/issues/234#issuecomment-924323319) (#234)
-	Fixed bug where the filtered episode lists would end prematurely, and hence unscrollable, if there were less displayable episodes and date separators than the length of the episode list.
-	Update version number to v1.28.1.
@Xunius
Copy link

Xunius commented Feb 17, 2022

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

@pessimal
Copy link

Hi, are we expecting a new release any time soon. I also got the queue issue from Linux AppImage release.

Bump for anniversary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@leighsmith @Xunius @kadykov @Mpkch @Desconvidado @pessimal