Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to use a custom plugin #15

Open
cmelbye opened this issue Aug 5, 2014 · 1 comment
Open

Not possible to use a custom plugin #15

cmelbye opened this issue Aug 5, 2014 · 1 comment

Comments

@cmelbye
Copy link

cmelbye commented Aug 5, 2014

I'm attempting to add NewRelic to my Go application running on Google App Engine. As far as I can tell it's not possible to use a custom plugin instead of newrelic_platform_go.NewrelicPlugin (which would be required on App Engine) in this package because of the unexported plugin property of Agent.

This is a curious choice, because it seems as if there's already an interface in the newrelic_platform_go package (newrelic_platform_go.INewrelicPlugin) that would allow for custom plugins to be used instead of the default one. (There are a couples places in this package where an interface wouldn't work, such as line 118 of agent.go, but that seems fixable.)

Was this a conscious decision, or is it something that could be changed? If you don't think this would be a good change, forking this repository for App Engine would work, but that doesn't seem like a great solution to me.

@yvasiyarov
Copy link
Owner

@cmelbye for sure it can be changed. You can just send me pull request and I will merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants