Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All improvements are welcome! #7

Open
yura505 opened this issue Feb 26, 2018 · 14 comments
Open

All improvements are welcome! #7

yura505 opened this issue Feb 26, 2018 · 14 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yura505
Copy link
Owner

yura505 commented Feb 26, 2018

This project is looking for new ideas, new pull requests, any improvements. Everything for make it better. Robinbot wants to be more flexible and configurable, go beyond the limited functionality.
Also nobody knows how it works on Windows platform. Let's create free trading bot together.

@yura505 yura505 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 26, 2018
@Geczy
Copy link

Geczy commented Mar 7, 2018

Works fine in Windows
Why do you suggest only running it at end of market? What if it's ran twice a day, beginning and end?

@yura505
Copy link
Owner Author

yura505 commented Mar 7, 2018

@Geczy It because the bot takes into account current day OHLC, however "close" of current day is not defined until market closed. The bot uses last trade price as "close", so as near to market end as accurate technical analysis will be. If you run the bot in the middle of day, there can be repaint effect or wrong signal taken. The bot created for swing and position trading, not for day trading. So, if run it in the beginning of day, you can take wrong signal (ex. BUY), but at the end of the day signal could be changed to SELL. As result you can loose money and this trade will be considered as "day". 3 day trades / week = block your account until you deposit $25k.

@zerowebcorp
Copy link

Is it possible to adjust this to use daily 1d1m chart for day trading?

@yura505
Copy link
Owner Author

yura505 commented May 7, 2018

@getvivekv Yes, it possible to adjust it, but need to have 1m data source for it, as I know it's expensive. However it you have data source, we can discuss code changes.

@zerowebcorp
Copy link

zerowebcorp commented May 7, 2018

@yura505 Real-time free data.

https://www.google.com/finance/getprices?i=30&p=1d&f=d,o,h,l,c,v&df=cpct&q=AMD

There is also a Price History api from TDAmeritrade that I am currently evalulating to see if it is real time or not.
https://developer.tdameritrade.com/price-history/apis/get/marketdata/%7Bsymbol%7D/pricehistory

@yura505
Copy link
Owner Author

yura505 commented May 8, 2018

@getvivekv Google finance is too unstable data source, I tried it before. They discontinued this service in 2011, it still works, but it's not good for use. The same with Yahoo finance.

@zerowebcorp
Copy link

Alright, fair enough. I have a source from where we can get 5 minutes data, not 1minutes. Also, I am waiting for a response from TDAmeritrade to see if theirs returns live data or not. Will let you know soon.

@yura505
Copy link
Owner Author

yura505 commented May 8, 2018

@getvivekv 5 min data is not a problem, it can be taken from Robinhood, but need for check that there real-time data:

GET /quotes/historicals/?symbols=$csv_symbols&interval=$i[&span=$s&bounds=$b] interval=week|day|10minute|5minute span=day(default)|week|year|5year|all bounds=extended|regular|trading(default)

From here: https://github.com/sanko/Robinhood/blob/master/Quote.md

@zerowebcorp
Copy link

That's great. I do believe this is realtime. But yes, agreed, we need to check.

If those are real-time data, how much effort would there be for code adjustment? I am myself a developer, but not familiar with nodejs, otherwise I would have submitted a pull request. But anything I can be of help, let me know

@yura505
Copy link
Owner Author

yura505 commented May 9, 2018

@getvivekv I think need just make some changes only in quotes.js, by default it downloads 2 years daily data from iextrading.com, but it's possible to rework it to make it configureable through conf.js for day trading too.

@zerowebcorp
Copy link

TDAmeritrade confirmed that the data they are reporting is live/realtime if you have a live account with them.

@zerowebcorp
Copy link

@tuner562
Copy link

I use Interactive Brokers with a data subscription, is it possible to use them as my source for rt data?

@Nick8197
Copy link

Have you looked into adding options trading on this bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants