Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node-notifier instead of terminal-notifier #4

Open
MoOx opened this issue Jul 15, 2014 · 2 comments
Open

Use node-notifier instead of terminal-notifier #4

MoOx opened this issue Jul 15, 2014 · 2 comments

Comments

@MoOx
Copy link

MoOx commented Jul 15, 2014

Now that Window build of Atom is provided, you should use a cross-os notification system.
node-notifier will do that job pretty well I think.

@yujinakayama
Copy link
Owner

Actually I tried to use the node-nofitifer package (and some other similar node packages) when I created this package, but I chose to use the raw terminal-notifier because the existing node packages didn't provide an interface to terminal-notifier's -sender option.

That said, I agree that it would be better to use more generic package and support Windows. I'll think a solution for this.

@walles
Copy link

walles commented Jul 3, 2015

Not sure if it existed when you wrote this, but nowadays https://atom.io/docs/api/v1.0.0/NotificationManager seems to be how notifications should be done in Atom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants