Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include *-coverage.js files in release builds #7

Open
derek opened this issue Jun 17, 2013 · 1 comment
Open

Don't include *-coverage.js files in release builds #7

derek opened this issue Jun 17, 2013 · 1 comment

Comments

@derek
Copy link
Contributor

derek commented Jun 17, 2013

Is there a reason we're including the coverage files in the release/CDN builds? For example, http://yui.yahooapis.com/3.10.0/build/yui/yui-coverage.js

yui3:master $ find ./release/3.11.0pre/cdn/build/ -name *-coverage.js | wc -l
     345

Also, inclusion of these files accounts for 47% of the build directory's 34M size.

yui3:master $ du -sh release/3.11.0pre/cdn/build/
 34M    release/3.11.0pre/cdn/build/
yui3:master $ find ./release/3.11.0pre/cdn/build -name *-coverage.js  -exec du -ch {} + | tail -n 1
 16M     total

If there isn't a reason to include the coverage files, we should block them from being copied over during grunt release.

@caridy
Copy link
Member

caridy commented Jun 17, 2013

Aside from the regular use case (generating coverage info while testing), @davglass has this idea in mind to use the coverage version to do dynamic analysis on webapps, something like: run your app with filter=coverage and collect some information about how much of the library is the app really using, the results will be surprising for sure. In most cases, you're really only using a very very tiny % of the library. I think that will be a valid case if we can put in place the pieces to provide the proper report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants