You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm seeing the tests fail as below on i686 and armv7hl platforms due to insufficient addressable memory. Can we reduce the size of these allocations in the test, while preserving the tests integrity? I suspect these are the relevant lines in golcs_test.go ...
left := make([]interface{}, 100000) // takes over 1 sec
right := make([]interface{}, 100000)
I've also experimented with changing those two 100000 values - reducing them to 5000 results in intermittent test passes, depending on how quickly the test now runs. I saw passes on the 32bit boxes subsequently, but one failure on x86_64 when the test ran in 0.85 seconds (defeating the 1sec sleep in the test).
A test like this is inherently unstable. Some people might have slower systems and some might have faster ones, but eventually everyone will have a system too fast for this to work. It's better to use some sort of ratio, like 1000× the size should take 1000× the time (or whatever the scaling should be.)
I'm seeing the tests fail as below on i686 and armv7hl platforms due to insufficient addressable memory. Can we reduce the size of these allocations in the test, while preserving the tests integrity? I suspect these are the relevant lines in golcs_test.go ...
This is the test log ...
The text was updated successfully, but these errors were encountered: