Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo command not saved after exiting for all command #9

Open
yu-ming-chen opened this issue Nov 13, 2020 · 1 comment
Open

Undo command not saved after exiting for all command #9

yu-ming-chen opened this issue Nov 13, 2020 · 1 comment

Comments

@yu-ming-chen
Copy link
Owner

yu-ming-chen commented Nov 13, 2020

used delete command
Screenshot 2020-11-13 at 5.14.36 PM.png
Screenshot 2020-11-13 at 5.14.47 PM.png
Screenshot 2020-11-13 at 5.14.57 PM.png

after exited item still deleted

@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

It does not cause the application to be unusable. The definition of high severity is: "A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users." Most users would not exit before executing a command other than undo, which would not cause this issue of not saving the current state of the food inventory.
Thus, the severity should be medium.

Items for the Tester to Verify

❓ Issue severity

Team chose [severity.Medium]
Originally [severity.High]

  • I disagree

Reason for disagreement: I feel that this should be a high severity issue.
As you have stated:
The definition of high severity is: “A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users.”
You have mentioned that "It does not cause the application to be unusable." However, it does not need to make the application unusable for it to be a high severity problem. As unusable was just an example given. However, this problem fullfill the "causes major problems for users" part. Imagine a user use the command"edit" to edit some information, however he realised those information were wong and decided to undo the operation. After he undo, he exits the app. Next thing you know when the user use the app again, all his original data are gone and there is no way of recovering those unedited data. This is definitely a major problem let's say the user use the app in the long term.

Furthermore, you stated that "Most users would not exit before executing a command other than undo, which would not cause this issue of not saving the current state of the food inventory." I feel that as a developer, this is an assumption that we should not make, we should not assume that "most" user would not exit before executing a command other than undo. A clear example will be the one i mentioned above and that is exactly how I spotted the bug in the first place.

I feel that having the possibility of data loss or unintentional tempering with data stored in storage is and will be a major problem to the user as they can loss everything in this case. Therefore, the severity level should be high.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants