Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instantiating an interface #10

Open
yu-ming-chen opened this issue Nov 13, 2020 · 1 comment
Open

Instantiating an interface #10

yu-ming-chen opened this issue Nov 13, 2020 · 1 comment

Comments

@yu-ming-chen
Copy link
Owner

yu-ming-chen commented Nov 13, 2020

Model is an interface, ":Model" refers to an instance of an interface. However, interface canot be instantited, therefore, it should be ModelManager here.
Screenshot 2020-11-13 at 5.18.29 PM.png

@nus-se-bot
Copy link

nus-se-bot commented Nov 18, 2020

Team's Response

This issue is inherited from AB3, thus, this bug is rejected with its severity downgraded to VeryLow.

(with reference to https://github.com/nus-cs2103-AY2021S1/tp/blob/master/docs/DeveloperGuide.md)

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: The team mentioned it is an issue inherited from AB3. According to the lecture it is stated that objects in sequence diagram are instances, therefore my team have changed it to ModelManager thinking that AB3's sequence diagram is wrong. AB3's error should not be used to justify the error in the diagram. Therefore, this should still be an wrong annotation in the sequence diagram.


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: This should at least be a low severity, imagaine developers looking at this diagram thinking that we instantiate an Mobel object which is not possible as it is an interface. They are not looking at your code base therefore will not know this information.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants