Wrong error message for invalid index for edit instruction

[yu-ming-chen]

When "edit 1.2 d/baked beans e/1-1-2020" is entered with a invalid decimal index, the error shown is invalid format instead of invalid index.

It should be.

[nus-se-bot]

Team's Response

This is not a bug, as stated in the User Guide, the index has to be an integer. In the example command used above, the provided index is a double value hence it is an invalid command format as the type is different from integer. The second error message shown above is when a valid command such as "edit 100 d/baked beans" but the index exceeds the number of food items is entered. In this case, the value "100" is an integer thus it is a valid command format but invalid index value. The error message is intended by us and aligns with the requirement stated in the UG, thus it is not a functionality bug. Furthermore, this does not affect the usage of the app as user will still be informed of the error. Hence, it is downgraded and rejected.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: I feel that using the info in the userguide is avoiding the problem. In this case, there is a contrast in what the app is telling the user what is wrong and what the userguide is saying. For example lets say a user keyed in "1.0" by accident as the index. The app will be saying that the format is wrong and this will result in users refering to the format of the command and try to locate if there are missing parameters and format. However, this is clearly a case where the index should be a positive integer stated in the user guide. A clearer error message will be this one below that is used in other command errors. Therefore, wrong index error is implemented but not used in this case.

---

❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Medium]

• I disagree

Reason for disagreement: [replace this with your explanation]

---