New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use performance.now() instead of new Date for measuring performance in demo? #9

Open

trivikr opened this issue Apr 11, 2019 · 0 comments

trivikr commented Apr 11, 2019 •

edited

Loading

Hi,

I noticed that demo use new Date for measuring performance metrics

downscale/demo/multiselect.js

Lines 143 to 148 in 6260f6d

    
           var start = new Date 
        
           canvasResize(source, WIDTH, HEIGHT). 
        
           then(function(r) { 
        
             canvTime = (new Date) - start 
        
             next(r) 
        
           })

Should it use performance.now() instead?

it's more precise in orders of magnitude (SO answer)
Google lighthouse audit also recommends using performance.now() over Date (link)

Regards,
Trivikram

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment