Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling NAN values in NMF #29

Open
PolarBean opened this issue Apr 26, 2024 · 2 comments
Open

Handling NAN values in NMF #29

PolarBean opened this issue Apr 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PolarBean
Copy link

There is this fantastic pull request in sklearn which does not apply the loss value to parts of the matrix which have nan values. scikit-learn/scikit-learn#8474
Is this possible in pytorch-NMF at present?

@yoyolicoris
Copy link
Owner

Hi @PolarBean , thanks for asking.
I have a very brief look at the PR you mentioned.
It looks like it's a weighted version of NMF, and can be handled with masked tensors.
https://pytorch.org/tutorials/prototype/maskedtensor_overview
I'll have a proper look when I have the time, but it sounds doable.

@yoyolicoris yoyolicoris added the enhancement New feature or request label Apr 26, 2024
@PolarBean
Copy link
Author

very interesting, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants