Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batched NMF example on large matrix #27

Open
yoyolicoris opened this issue Jan 28, 2023 · 4 comments
Open

Batched NMF example on large matrix #27

yoyolicoris opened this issue Jan 28, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@yoyolicoris
Copy link
Owner

yoyolicoris commented Jan 28, 2023

Reference:

@yoyolicoris yoyolicoris added the enhancement New feature or request label Jan 28, 2023
@yoyolicoris yoyolicoris self-assigned this Jan 28, 2023
@austinv11
Copy link

Hello,

Has there been any update on this? I am interested in applying this to large datasets and would love to be able to run my data in batches, but I am not entirely sure how to best do it with your package.

@yoyolicoris
Copy link
Owner Author

Hi @austinv11, nice to know you're interested in this.

I plan to implement something similar to this paper to perform NMF on extensive data that cannot be fitted entirely into memory.
The mini-batch update scheme doesn't fit the current interface of torchnmf.nmf.BaseComponent and needs a new class to handle it.
However, I'm working on other projects and won't work on this soon.

@yoyolicoris yoyolicoris moved this from Todo to In Progress in @yoyololicon's Kanban Apr 2, 2024
@KendallPark
Copy link

KendallPark commented Apr 21, 2024

@yoyololicon I see this is moved into "In Progress." How goes the implementation? I am interested in applying NMF to very large datasets as well. None of the PyTorch NMF implementations have this feature. Your repo is the best coded and documented compared to the other options out there.

It would be great to have it work with PyTorch DataLoaders and Datasets. If not I might be able to contribute that aspect.

@yoyolicoris
Copy link
Owner Author

Hi @KendallPark, thanks for asking.

Glad to know you're also interested in this.
My collaborator and I are working on this feature, and we hope to make it available this summer.

It would be great to have it work with PyTorch DataLoaders and Datasets. If not I might be able to contribute that aspect.

I'm not sure how the feature will work with PyTorch dataloaders... (I feel the use case here is different from regular deep learning training.)
It would be better if you could elaborate more on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

3 participants