Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign IFC properties #81

Open
bje- opened this issue Sep 29, 2021 · 4 comments
Open

Redesign IFC properties #81

bje- opened this issue Sep 29, 2021 · 4 comments
Assignees
Labels
Feature New feature or request

Comments

@bje-
Copy link

bje- commented Sep 29, 2021

I am trying to add some custom properties to objects in FreeCAD so that they appear in the exported IFC file. Do these need to be added in a particular way for this to happen?

@bje- bje- changed the title Unable to generate custom properties than are exported to IFC Unable to generate custom properties that are exported to IFC Sep 30, 2021
@yorikvanhavre
Copy link
Owner

Sorry, I ended up overlooking this 😬
There is currently no way to do this apart from using the IFC properties manager. There, you can create an IFC property set and adding custom properties to it.

But there is some time I think we should switch to a full FreeCAD properties system. That is, all the IFC properties appear in the FreeCAD object properties, and vice-versa (all FreeCAD object properties are saved to IFC).

This is a good opportunity to define how to do this. The problems I see:

  • Not all FreeCAD properties must be exported to IFC. Some are internal to FreeCAD.
  • Not all FreeCAD properties CAN be exported to IFC. Ex: Placements
  • Some IFC properties might need to be mapped to existing, default FreeCAD properties. Ex, name

We could do this in different steps:

  1. Keep everything as it is, and additionally export some FreeCAD custom properties as IFC properties
  2. Find a system to deal with different or unsupported property types
  3. Migrate the current IfcProperties dict to FreeCAD properties
  4. Redesign the IFC Properties manager

@bje-
Copy link
Author

bje- commented Dec 2, 2021

Sounds good. I am not a FreeCAD developer, I just want something That Works. :-)

@yorikvanhavre
Copy link
Owner

yorikvanhavre commented Feb 22, 2022

Redesign plan

Sync between IFC properties and FreeCAD properties

In Arch:

  • IFC properties are stored as FreeCAD properties
  • Alternate idea 1: Only additional properties are added as FreeCAD properties. psets are still handled the current way
  • Alternate idea 2: Psets are stored as App::PropertyMap. PropertyMap editor needs to be implemented
  • Property sets are stored as FreeCAD property groups
  • Need a conversion map between FreeCAD property types and IFC property types
  • IFC Importer: map to FreeCAD properties
  • IFC exporter: map from FreeCAD properties

In BIM:

  • Redesign of the properties manager UI: Allow to add/remove properties (sync with FreeCAD properties), mark groups as exported to IFC or not, import property sets

@yorikvanhavre yorikvanhavre self-assigned this Feb 22, 2022
@yorikvanhavre yorikvanhavre changed the title Unable to generate custom properties that are exported to IFC Redesign IFC properties Feb 22, 2022
@yorikvanhavre yorikvanhavre added the Feature New feature or request label Apr 7, 2022
@yorikvanhavre
Copy link
Owner

First test in 123440c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants