-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more languages and locales #27
Comments
Thank you for opening the issue! So I think the easiest option is to maintain a mapping between language words the English words we use at the regexes here |
I'll start by making types of regexes. for example, export type FormatDiagnosticMessageTarget =
| "DeclareModuleSnippet"
| "MissingPropsError"
| "TypePairs"
| "TypeAnnotationOptions"
| "Overloaded"
| "SimpleStrings"
| "Types"
| "ReversedTypes"
| "SimpleTypesRest"
| "TypescriptKeywords"
| "ReturnValues"
| "RegularCodeBlocks"; (I have no clue what kind of those regexes are, but I guessed from your very detailly described comments) and making some constants with type at /src/format/i18n type LocaleFormatDiagnosticMessageTarget = Record<FormatDiagnosticMessageTarget, RegExp>
// en.ts
const en:LocaleFormatDiagnosticMessageTarget = {
DeclareModuleSnippet: /'(declare module )'(.*)';'/g,
...
} Which will be constructed like What do you think of it? |
This makes me see the hope of other languages |
btw, it would be great to have a detailed contribution document. I'm trying to find out how to test & watch in the development environment. and also example codes which generates each error messages |
Has the same request, hope to support Chinese in the future version~ |
@yoavbls I'm keep struggling on executing this repository in development environment. I'm novice to vscode extension, so could you help me how to do it? |
@JUSTIVE Sorry for my late response and thank you for all the effort and the contribution even though there is no contribution guide. |
yes, I'm available on discord, my handle is |
@yoavbls, Any progress? Thanks for your input! |
@CzarOfScripts Sorry, no progress happened. |
Syntax highlighting should be fixed in other languages(Korean, in this case).
If you're unfamiliar with other languages that reproduce these kinds of issues, I'll try to contribute PR with this issue.
The text was updated successfully, but these errors were encountered: