Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh span name when trace completes in traces list #161

Open
codefromthecrypt opened this issue Sep 18, 2024 · 3 comments
Open

refresh span name when trace completes in traces list #161

codefromthecrypt opened this issue Sep 18, 2024 · 3 comments
Assignees

Comments

@codefromthecrypt
Copy link

Right now, the trace list has the first span name to complete, not the first span name to start (root trace) in the list. I can't seem to have this refresh to see the much better name.

Example, when the trace is complete, I want to see "user" not "POST" for the last span, or be able to hit '/' and have it fix the list.

Screenshot 2024-09-18 at 4 33 17 PM
Screenshot 2024-09-18 at 4 33 30 PM

@ymtdzzz
Copy link
Owner

ymtdzzz commented Sep 18, 2024

Certainly, the spans shown in the list are the service root spans "at the time of arrival at otel-tui".
Real-time updating would be implemented by modifying AddSpan() to check if the received span is a parent of the currently stored service root span and swap them if necessary.

I'd like to work on this issue after closing #18 :)

Thanks for the suggestion as always!

@ymtdzzz ymtdzzz self-assigned this Sep 19, 2024
@ymtdzzz
Copy link
Owner

ymtdzzz commented Oct 22, 2024

I'm planning to work on this issue next week (after Kaigi on Rails 2024).

@ymtdzzz
Copy link
Owner

ymtdzzz commented Oct 29, 2024

@codefromthecrypt , I think #172 solves this issue, could you check in that branch if you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants