Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it seem the url parameter can be removed? #573

Open
TiaNex-Com opened this issue Mar 5, 2023 · 2 comments
Open

it seem the url parameter can be removed? #573

TiaNex-Com opened this issue Mar 5, 2023 · 2 comments
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@TiaNex-Com
Copy link

CommonViewInjection.php
there is $urlGenerator in view now,

What steps will reproduce the problem?

What is the expected result?

What do you get instead?

Additional info

Q A
Version 1.0.?
PHP version
Operating system
@vjik
Copy link
Member

vjik commented Mar 5, 2023

Yes. url here duplicate urlGenerator from params.

@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Mar 5, 2023
@samdark samdark removed the question label Jun 4, 2023
@samdark
Copy link
Member

samdark commented Jun 4, 2023

It is now there but we should rename it from url to urlGenerator. Reasons:

  1. It's less likely to cause naming conflict.
  2. It's like there in yiisoft/app already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@samdark @vjik @TiaNex-Com @rustamwin