Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to a specific line or log message number #9

Open
diy1 opened this issue Mar 2, 2023 · 2 comments
Open

Jump to a specific line or log message number #9

diy1 opened this issue Mar 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@diy1
Copy link

diy1 commented Mar 2, 2023

Request

There doesn't seem to be a way to jump to a particular line. This is particularly useful when a user sets a large number of log events per page (so that the entire file is loaded in one page so that one can search the entire file).

Possible implementation

Add this feature. (If we can have a VIM mode that supports basic VIM commands, including jump-to-a-line, would be even better.)

@diy1 diy1 added the enhancement New feature or request label Mar 2, 2023
@jackluo923
Copy link
Member

Jumping to a specific line when you have a large number of log events in a single page is already well supported. The functionality is implemented by the monoco editor library (visual studio code editor) and the default shortcut is ctrl + g for all platforms.

Vim key bindings already exist for vscode and it shouldn't be too difficult to add it to the log viewer UI at a later time. For now, press F1 in the log-viewer to browse through the existing key-binding to all of the monoaco editor features.

@vishalpalaniappan
Copy link
Contributor

Jumping to a specific line when you have a large number of log events in a single page is already well supported.

Adding to this: For now, to go to a specific log event, you can also change the value of logEventIdx in the URL hash parameter. We will be adding support to do it through Monaco (with keyboard shortcuts) soon.

junhaoliao referenced this issue in junhaoliao/yscope-log-viewer Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants