STM32f407_evk Board Config Issues

[Ryzee119]

Hello, great project, it is working very well for me. I did notice these small issues when working with the STM32F40 that may be worth looking at:

Confusing comment

TeenyUSB/demo/boards/stm32f407_evk/board.c

Lines 55 to 64 in 303431c

	/**USART3 GPIO Configuration
	PC7 ------> USART6_RX
	PC6 ------> USART6_TX
	*/
	GPIOC->MODER &= ~ (MODE(3,10) | MODE(3,11));
	GPIOC->MODER |= (MODE(2,10) | MODE(2,11));
	GPIOC->OTYPER &= ~(TYPE(1,10) | TYPE(1,11));
	GPIOC->OSPEEDR |= (MODE(3,10) | MODE(3,11));
	GPIOC->AFR[1] &= ~(AF(0xf,10) | AF(0xf,11));
	GPIOC->AFR[1] |= (AF(GPIO_AF7_USART3,10) | AF(GPIO_AF7_USART3,11));

This comment does not reflect the actual pin numbers. Should be UART3 and PC11 and PC10

HOST_PORT_POWER_ON_FS should be active low?

TeenyUSB/demo/boards/stm32f407_evk/board_config.h

Lines 115 to 121 in 303431c

	#define HOST_PORT_POWER_ON_FS() \
	do{\
	__HAL_RCC_GPIOC_CLK_ENABLE();\
	GPIOC->MODER &= ~(GPIO_MODER_MODER0 << (1*2));\
	GPIOC->MODER |= (GPIO_MODER_MODER0_0 << (1*2));\
	GPIOC->BSRR = GPIO_PIN_1<<16;\
	}while(0)

Refer user manual page 30/34. I had to change this section of code to enable VBUS at the USB connector.

Thank you!
Regards
Ryan

[xtoolbox]

My 407 Evk board is this one, Waveshare EVK407I. The power switch use active low logic.

Thanks

[Ryzee119]

Thank you, yes looks correct to that board. Nice work.