Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performances on Windows #663

Open
JohanMabille opened this issue Mar 1, 2018 · 6 comments
Open

Performances on Windows #663

JohanMabille opened this issue Mar 1, 2018 · 6 comments

Comments

@JohanMabille
Copy link
Member

We should consider the following options to improve performances on Windows:

  • use FORCE_INLINE when possible
  • reintroduce the const member in const_array; this gives an Internal Compiler Error, that can be removed by removing the noexcept qualifier of the methods of const_array.
@SylvainCorlay
Copy link
Member

I think that the changes in const_array with the conditionals on MSVC can be introduced as a compiler workaround. I am more hesitant about having a XTENSOR_INLINE macro....

@JohanMabille
Copy link
Member Author

JohanMabille commented Mar 1, 2018

This is required if we want to reduce the overhead we have on Windows (on my machine, for small containers, we are 50% slower than Eigen without it, and "only" 20% with it).

@SylvainCorlay
Copy link
Member

Yeah, maybe in two different PRs 😒

@JohanMabille
Copy link
Member Author

I agree, replacing inline with XTENSOR_INLINE everywhere should be done in a dedicated PR.

@SylvainCorlay
Copy link
Member

Also, do we want to replace all the inline with XTENSOR_INLINE?

@wolfv
Copy link
Member

wolfv commented Mar 1, 2018

does the const qualifier make a difference in performance?

I think XTENSOR_INLINE makes sense if we can measure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants