Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout as template parameter #231

Closed
JohanMabille opened this issue Mar 30, 2017 · 2 comments
Closed

Layout as template parameter #231

JohanMabille opened this issue Mar 30, 2017 · 2 comments

Comments

@JohanMabille
Copy link
Member

JohanMabille commented Mar 30, 2017

Containers in xtensor should take an additinoal layout template parameter with three possible values:

  • row_major
  • column_major
  • dynamic_layout

This would facilitate the integration of BLAS libraries and the use of SIMD intrinsics for most common layouts. Doing this, the following items should be taken into account:

  • in place transpose should be disabled for row_major / column_major. In order to keep consistency, I think we could remove these functions from the xcontainer interface and add a transpose view. This would break backward compatibility.
  • the reshape(const shape_type&, const strides_type&) overload should be disabled for row_major / column_major.
@wolfv
Copy link
Member

wolfv commented Apr 4, 2017

Sounds good. I'd propose a strided_view.
That'll most likely also work for #161 :)

@JohanMabille
Copy link
Member Author

Implemented in #255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants