Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer overflow #15

Open
vargac opened this issue Sep 29, 2017 · 1 comment
Open

Integer overflow #15

vargac opened this issue Sep 29, 2017 · 1 comment
Assignees

Comments

@vargac
Copy link
Member

vargac commented Sep 29, 2017

Using helpful functions to obtain realworld and image distances may be dangerous, because of multiplication focal length by realworld distance in cm. For example X * Fxp is getPixX. Both variables are defined 16 bits wide, Fxp = 260 in example, so X should be less than 127 - that's not much.

@vargac
Copy link
Member Author

vargac commented Sep 29, 2017

What about using int32_t datatype? @mrshu I worry I need your help about complexity, as I don't understand it, although I've read some forums/articles. (I have to admit that only superficially read - I was expecting straightforward results)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants