Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup local rescanning is caused by “Rescan now” shying away in a corner #1606

Open
shenlebantongying opened this issue Jun 21, 2024 · 3 comments

Comments

@shenlebantongying
Copy link
Collaborator

shenlebantongying commented Jun 21, 2024

tl;dr: changes that makes sence

  • Option to disable startup rescanning
  • Add a button ing Edit menu for easy rescan without restart or opening the dictionary dialog

Info

Usability issues:

  • Startup checking is not really necessary boost startup speed  #504
  • The tab is very loooong and may grow in the future, new tabs are maybe invisible unless the user has a giant screen.
  • Add a new dict to while adding files when a path is already in "Files", the user needs to open the dialog then close.
  • Editing other “somewhat dictionaries” like “Programs” doesn't really need to "rescan" at all
  • Cannot open Edit Groups dialog directly.
  • There is no "rescan now" button in "Sound Dir" tab.
  • Both The opening and "Ok" button of this dialog carries lots of responsibilities

How about1

  • Split them into different dialogs
  • Change the modality of "Inspect dictionaries" and "Manage groups" dialog, so that "Edit local files", "Inspect dictionaries" and "Manage groups" can be opened in parallel. (Maybe a bad idea.)
  • Remove startup scan
  • Automatic "Rescan now" in the “local dictionary” dialog only
  • Add a quick "Rescan/Reindex now" in menu

Outcome

Footnotes

  1. I am pretty aware of the cost of implementing this, this is yet another idea. 😅

@shenlebantongying shenlebantongying changed the title Startup local dictionary rechecking is because “Rescan now” is shying away in a corner Startup local rescanning is caused by “Rescan now” shying away in a corner Jun 21, 2024
@xiaoyifang
Copy link
Owner

xiaoyifang commented Jun 22, 2024

the startup checking based on the following assumption that
the dictionaries may have changed before the gd-ng start.
Eg, add a new dictionary in the monitored dictionary path.

Without the startup checking , the gd-ng will lost the chance to reflect the new changes in the dictionary.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Jun 22, 2024

  • Change the modality of "Inspect dictionaries" and "Manage groups" dialog, so that "Edit local files", "Inspect dictionaries" and "Manage groups" can be opened in parallel. (Maybe a bad idea.)

groups depends on dictionaries . As long as the dictionaries do not change during the above operation .this should be ok.

@xiaoyifang
Copy link
Owner

xiaoyifang commented Jun 22, 2024

  • Automatic "Rescan now" in the “local dictionary” dialog only
  • Add a quick "Rescan/Reindex now" in menu

Sound ok,
But with the startup checking , a quick "Rescan/Reindex now" in menu may never get the chance to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants