Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I find a bug in canvas2image.js #295

Open
jacklincao opened this issue Dec 6, 2018 · 2 comments
Open

I find a bug in canvas2image.js #295

jacklincao opened this issue Dec 6, 2018 · 2 comments

Comments

@jacklincao
Copy link

When I use scene.canvas.getSnapshot, The img's height is incorrect, and I find line 154 have 2 iwidth in canvas2image.js, It's should be oSaveCtx.drawImage(oCanvas, 0, 0, oCanvas.width, oCanvas.height, 0, 0, iWidth, iHeight);

@xeolabs
Copy link
Owner

xeolabs commented Dec 6, 2018

Thanks! If you like, please make a PR and then I'll merge. This bug has actually been affecting users, so it's great that you found this.

@jacklincao
Copy link
Author

ok, I will make a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants