Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: add support for context.Context #75

Open
aofei opened this issue Mar 6, 2021 · 1 comment
Open

[FEAT]: add support for context.Context #75

aofei opened this issue Mar 6, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aofei
Copy link
Contributor

aofei commented Mar 6, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

I think people may prefer to have the ability to cancel their requests at any time.

Describe the solution you'd like

Add context.Context to every func/method that involves network operations.

Describe alternatives you've considered

N/A

Additional context

This isn't a difficult feature to implement. What needs to be considered is the API compatibility (since this module have already released v1.0.0).
@aofei aofei added the enhancement New feature or request label Mar 6, 2021
@quenbyako
Copy link
Member

leave this link just for my info, don't mind it

@quenbyako quenbyako added the good first issue Good for newcomers label Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aofei @quenbyako