Should remove the panic?

[waybackarchiver]

The panic in this code looks like used for debugging. I guess that should remove it?

mtproto/mtproto.go

Lines 364 to 367 in 04ee89d

	case *objects.BadMsgNotification:
	pp.Println(message)
	panic(message) // for debug, looks like this message is important
	return BadMsgErrorFromNative(message)

[quenbyako]

@waybackarchiver well, yes, but no. BadMsgNotification means that all session was broken, i mean, this message should be never received from official telegram servers. if we got it, then something in package is broken.

Soooo, idk, maybe we need to leave for now... Or remove it, cause i hate panics in community modules too...

I don't know, need to decide what to do with it.

[waybackarchiver]

As I understand it, we should provide this panic as an error to the caller to handling, and not have them interrupted.

But I haven't encountered this yet, so maybe I'll consider it later if we need to.

[sunnyque]

return error (or mark session is in bad state) and let app decide what to do (panic or reconnect/recreate session). at this time I've been forced to separate app logic using different processes because of mtproto panics (lost connection/BadMsgNotification whatever)