Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Wildcard in Oauth2 redirect urls #60

Open
josephpage opened this issue Jan 31, 2017 · 5 comments
Open

[Auth] Wildcard in Oauth2 redirect urls #60

josephpage opened this issue Jan 31, 2017 · 5 comments

Comments

@josephpage
Copy link
Contributor

josephpage commented Jan 31, 2017

Ca serait très pratique si on pouvait mettre des wildcard dans les redirect url d'une app Xee (dans le dashboard développeur). Par exemple, pouvoir mettre :

http://localhost:8080/*
ou
https://myapp.com/xee/*/callback

Au delà de faciliter le développement en local, mon cas d'usage en prod pour l'instant c'est le renouvellement du refresh_token (par exemple pour ajouter des scopes ou quand l'utilisateur change son mot de passe).
Dans ce cas on aimerait faire une requête de ce genre afin d'identifier quel compte on veut mettre à jour :
https://myapp.com/connections/xee/{xee_account_id}/renew

D'ailleurs à partir du moment où une app est publique dans le Xee Store ça serait peut-être une bonne chose d'obliger ces URLs à être en HTTPS afin d'éviter les attaques man-in-the-middle.

@josephpage josephpage changed the title Wildcard in Oauth2 redirect urls [Auth] Wildcard in Oauth2 redirect urls Jan 31, 2017
@josephpage
Copy link
Contributor Author

I'm quite sure you can implement it quickly @quentin7b !

@quentin7b
Copy link
Contributor

IMHO, the second idea is quite good.
But for the first one, I'm not sure..

Anyway, we'll see if it can be done simply, we don't know yet :)

@josephpage
Copy link
Contributor Author

Any updates ?

@josephpage
Copy link
Contributor Author

That is a basic feature. Many Oauth2 API providers implement it (FB, Google, etc)

@josephpage
Copy link
Contributor Author

I have found a solution using a JWT token in the state parameter.
But the request seems to me legitimate for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants