-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local attrbiutes #102
local attrbiutes #102
Conversation
xcapi.EXECUTE_API) | ||
} | ||
} | ||
loadedLocalAttributesResp, errToCheck := w.loadLocalAttributesIfNeeded(ctx, prep, task) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to merge when you feel like you have addressed all the comments. I will continue to work on top of it after you merge.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
- Coverage 63.10% 63.10% -0.01%
==========================================
Files 81 85 +4
Lines 6145 6331 +186
==========================================
+ Hits 3878 3995 +117
- Misses 2021 2077 +56
- Partials 246 259 +13 ☔ View full report in Codecov by Sentry. |
Why make this pull request?
[Explain why you are making this pull request and what problem it solves.]
What has changed
[Summarize what components of the repo is updated]
[Link to xdb-apis/sdk-go PRs if it's on top of any API changes]
How to test this pull request?
[If writing Integration test in Golang SDK repo, please provide link to the pull request of Golang SDK Repo]
[It's recommended to write integration test in Golang SDK repo, and enabled in this server repo first,
without enabling in the SDK repo. After this PR is merged, enable and merge the integration test in the SDK repo]
[Alternatively if Java/other SDK repo is preferred, then just test locally against server PR.
After the server PR is merged, merge the integration test in the SDK repo]
Checklist before merge
[ ] If applicable, merge the xdb-apis/sdk-go PRs to main branch
[ ] If applicable, merge the xdb-apis/xdb-apis PRs to main branch
[ ] Update
go.mod
to use the commitID of the main branches for xdb-apis/sdk-go