Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widevine][MacOs] Removed deprecated functions #1593

Closed
wants to merge 2 commits into from

Conversation

CastagnaIT
Copy link
Collaborator

@CastagnaIT CastagnaIT commented Jun 30, 2024

Description

CFBundleOpenBundleResourceMap and CFBundleCloseBundleResourceMap are deprecated from macOs 10.15
by a search seem that its not more needed call these functions since resources should be managed internally

Motivation and context

fix #1590

How has this been tested?

NOT TESTED!
i dont know apple enviroment and i dont have way to test

things to check:

  1. check if MAC_OS_X_VERSION_MIN_REQUIRED condition works
  2. test if on osx USE_BUNDLE_RES_MAP define will be set to enable it
  3. test tvos build

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT marked this pull request as draft June 30, 2024 11:28
@CastagnaIT CastagnaIT closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error compiling for tvOS - deprecated functions in lib/cdm/cdm/base/native_library_mac.mm
1 participant