Rework SettingsValuesViewController #1087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wutschel
force-pushed
the
rework_settingsvc
branch
4 times, most recently
from
2386a74
to
46e13bd
Compare
Massive rework of SettingsValuesVC to let labels automatically choose the correct height instead of scaling the font size down.
- Background black with alpha = 0.8 - Scrubbing speed text in lightGray
- New line after case section - Remove commented code - Remove obsolete empty lines - No space before method parameters - completion:nil - pragma with dash - pointer declaration w/o leading space
Only create once
- Warning uses [Utilities getSystemRed:0.95 - Standard uses TOOLBAR_TINT_COLOR
- Easier to read - Using new unicode icon
_tableView is only created later. Remove this non-working assignment.
Use stripBBandHTML instead of dedicated implementation. Apply stripping outside of the switch-case statement to apply it for all cases.
This ensures that the calculation of label heights is done after the cell and subview have been sized.
Remind that tableView:heightForHeaderInSection anyway returns 0.
wutschel
force-pushed
the
rework_settingsvc
branch
from
46e13bd
to
93fad6c
Compare
wutschel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #509. Yay! :)
This PR delivers a major rework of
SettingsValuesViewController. Main motivation was to set the label dimensions matching the text which needs to be displayed instead of hardcoding the dimensions or scaling down font sizes. While implementing this several other updates were obvious to be made ad well:slider,scrubbingViewandfooterViewwith App colorsfooterView(only create once)Screenshots (top = new, bottom = before):
Summary for release notes
Maintenance: Internal rework of SettingsViewController for better maintenance
Improvement: Automatically choose correct sizes for setting labels
Improvement: Place toggle switch next to setting name and not its description
Improvement: Better readability by larger fonts for setting description
Improvement: Remove "[CR]", BB and html code from descriptions
Improvement: Align scrubbingView, footer and slider colors with App colors