Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: limit font scaling for more consistent look #1084

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Jun 22, 2024

Description

Closes #1012.

Use minimumScaleFactor 1.0 if no scaling desired. Use 0.9 as default where different font sizes might disturb, e.g. for library/playlist views. Use 0.8 where different font sizes are not that disturbing.

Screenshots (left = before, right = new)
Bildschirmfoto-2024-06-23-um-17-30-20

Summary for release notes

Improvement: limit font scaling for more consistent look

@wutschel wutschel marked this pull request as ready for review June 23, 2024 10:39
@wutschel wutschel force-pushed the improve_fontscaling branch 3 times, most recently from d36e7d8 to 8d97642 Compare June 24, 2024 07:36
@wutschel wutschel marked this pull request as draft June 28, 2024 20:00
@wutschel wutschel marked this pull request as ready for review June 28, 2024 23:13
@wutschel
Copy link
Collaborator Author

Needs to be rebase after #1087 was merged.

@wutschel wutschel marked this pull request as draft June 29, 2024 09:13
Use 1.0 if no scaling desired. Use 0.9 as default where different font sizes might disturb, e.g. for library/playlist views. Use 0.8 where different font sizes are not that disturbing or even required.
Use same layout for both playlist and library view cell's main and sub labels. Move main labels slightly down to move closer to sub label.
For playlist cells right-align runtime and main label and let width of sub label autoresize to gain more space.
Increase size for program time, program details and recording details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review use of minimumScaleFactor
1 participant