Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[style] Fix up style in Inventory namespace #797

Open
stephen-hawley opened this issue Nov 28, 2023 · 0 comments
Open

[style] Fix up style in Inventory namespace #797

stephen-hawley opened this issue Nov 28, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Future

Comments

@stephen-hawley
Copy link
Contributor

Look over code and make changes including:

  • using var where it makes sense
  • clean up type-checking using the if (cl is SomeType varName) pattern
  • remove SomeType varName = null; if (values.TryGet(name, out varName) pattern and use if (values.TryGet(name, out varVarname))
  • Turn on #nullable enable
@stephen-hawley stephen-hawley added enhancement New feature or request good first issue Good for newcomers labels Nov 28, 2023
@stephen-hawley stephen-hawley added this to the Future milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@stephen-hawley