Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Convert ds.temporal._get_weights() to a public method #687

Open
tomvothecoder opened this issue Aug 27, 2024 · 0 comments
Open
Labels
type: enhancement New enhancement request

Comments

@tomvothecoder
Copy link
Collaborator

Is your feature request related to a problem?

This method should be turned public, similar to the ds.spatial.get_weights() method.

Describe the solution you'd like

  • Remove the references to class attributes (e.g., self.freq, self.mode) and make them method arguments.
  • Update downstream private methods to replace class attribute refs to method args

Describe alternatives you've considered

No response

Additional context

Also ds.spatial.get_weights() method should be listed in the API Reference page.

@tomvothecoder tomvothecoder added the type: enhancement New enhancement request label Aug 27, 2024
@tomvothecoder tomvothecoder changed the title [Enhancement]: Convert ds.temporal._get_weights() as a public method [Enhancement]: Convert ds.temporal._get_weights() to a public method Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New enhancement request
Projects
Status: Todo
Development

No branches or pull requests

1 participant