Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

const correctness #46

Open
superbigio opened this issue Nov 9, 2019 · 3 comments
Open

const correctness #46

superbigio opened this issue Nov 9, 2019 · 3 comments

Comments

@superbigio
Copy link

Would you be interested in making libltc const-correct?
I think it's a pretty simple API so it shouldn't be too difficult to do.
I think about a dozen of functions would be affected.

I may have a PR ready for this.
Let me know...

@x42
Copy link
Owner

x42 commented Nov 9, 2019

That'll likely break API and ABI, won't it?

@superbigio
Copy link
Author

Yes, adding const as a parameter qualifier will break ABI compatibility, but not API.
The API will still be able to compile and work, however there may be a few compiler warnings being thrown at you. (harmless but a little annoying) Although this also depends upon your compiler settings. If you give me permission to send you a PR I will do my best to get rid of all kinds of warnings and annoyances that such a change may produce.
However the ABI will break regardless.

@lp35
Copy link

lp35 commented Mar 31, 2020

Also interested by that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants