-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for conflicts when registering RequestDTO's as tags #1
Labels
Comments
wwwlicious
added a commit
that referenced
this issue
Apr 18, 2016
* Updating ss versions to .55 Adding default 'ServiceStack' tag to service registrations * Updating to use the IServiceGateway and adding ConsulServiceGatewayFactory and tests. Registering factory in plugin with IoC and removing IServiceClient registration Adding consul web ui plugin link on metadata page Changing plugin constructor to take a IServiceGateway delegate to allow consumers to customise client/config for external service calls. Updating demo's and readme to reflect changes. * removing dotsettings file * Fixing package refs * few readme corrections * Hiding health services from metadata page (#1) Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient Adding GatewayServiceDiscoveryException for all consul lookup exceptions Adding prefix to service and tag and healthcheck registration Adding service lookups by tag Adding service sorting by round trip times Adding service filtering by passing health Adding public member docs Adding tests Few readme updates * Fixing tests (#2) * Hiding health services from metadata page Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient Adding GatewayServiceDiscoveryException for all consul lookup exceptions Adding prefix to service and tag and healthcheck registration Adding service lookups by tag Adding service sorting by round trip times Adding service filtering by passing health Adding public member docs Adding tests Few readme updates * Fixing tests * Skipping test test works locally but fails on appveyor, getting expected message of test below suggesting state is being shared somewhere
wwwlicious
added a commit
that referenced
this issue
Apr 18, 2016
Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient Adding GatewayServiceDiscoveryException for all consul lookup exceptions Adding prefix to service and tag and healthcheck registration Adding service lookups by tag Adding service sorting by round trip times Adding service filtering by passing health Adding public member docs Adding tests Few readme updates
wwwlicious
pushed a commit
that referenced
this issue
May 27, 2016
…ket-master to master * commit '722edf09f89fc059ea8ea1f2eda6d799c10d13a5': Pr 12 (#13) Adding http caching to gatewayfactory (#11) Cleaned up and extended type selection to include RestrictAttribute Updated readme with type exclusion examples Refining service lookups for health checks (#6) Skipping test Fixing tests (#2) Fixing tests Hiding health services from metadata page (#1) Hiding health services from metadata page Moving service location logic from DefaultDiscoveryRequestTypeResolver to the ConsulClient Adding GatewayServiceDiscoveryException for all consul lookup exceptions Adding prefix to service and tag and healthcheck registration Adding service lookups by tag Adding service sorting by round trip times Adding service filtering by passing health Adding public member docs Adding tests Few readme updates Update HealthCheckServiceTests.cs Adding custom health checks (#5) few readme corrections Implement IServiceGateway changes (#4) Fixing package refs removing dotsettings file Updating to use the IServiceGateway and adding ConsulServiceGatewayFactory and tests. Registering factory in plugin with IoC and removing IServiceClient registration Adding consul web ui plugin link on metadata page Changing plugin constructor to take a IServiceGateway delegate to allow consumers to customise client/config for external service calls. Updating demo's and readme to reflect changes. Updating ss versions to .55 Adding default 'ServiceStack' tag to service registrations Update README.md Update README.md Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Accurate routing relies on the fact that a RequestDTO when registered as a tag will be unique to that AppHost's service registration name in consul.
when registering apphost requestDTO's (tags), a check should be done looking for any existing tag with the same name. If the existing tag is not another instance of the same service (even if a different version), then the registration should take a note of each duplicate type and throw these as a fatal exception preventing the service from starting as registration cannot succeed.
The text was updated successfully, but these errors were encountered: