Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalizing frame visual structure #49

Open
wtheisen opened this issue Aug 5, 2019 · 1 comment
Open

Generalizing frame visual structure #49

wtheisen opened this issue Aug 5, 2019 · 1 comment

Comments

@wtheisen
Copy link
Owner

wtheisen commented Aug 5, 2019

@noyoshi what do you think about pushing the visual(urwid) pieces of the frames up a level of abstraction? If we made tree view, and in-line box view generic inheritable methods it would make adding new sites incredibly easy. All the site frame would have to do is set up the data correctly and pass it to the generalized display function that's correct for the data and it'd set up the contents for the site.

@noyoshi
Copy link
Contributor

noyoshi commented Aug 6, 2019

I will look into the code on my flight, but what you are saying sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants