Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the public method name for addUser method in UserUniqueIDManger #22086

Open
Sachin-Mamoru opened this issue Dec 19, 2024 · 0 comments
Open

Comments

@Sachin-Mamoru
Copy link
Contributor

Sachin-Mamoru commented Dec 19, 2024

Current Limitation

addUser method name [1] in UserUniqueIDManger doesn't reflect its actual logic. What it actually does is generate a unique ID and add it against the user. Not actually adding a new user.

[1] https://github.com/wso2/carbon-kernel/blob/4.10.x/core/org.wso2.carbon.user.core/src/main/java/org/wso2/carbon/user/core/common/UserUniqueIDManger.java#L51

Suggested Improvement

Change the method name to something like addUniqueIdToUser or something meaningful.
And deprecate the current method.

Version

Latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant