ls_method = 1 bugs

[barronh]

ls_method = 1 does not appear to be operational. There are two major bugs that occur when using ls_method = 1 with correl or covar and gauss

1. arrays used within loop are deallocated after the first bin. This causes a segmentation fault.

GENBE_2.0/src/gen_be_stage4.F

Line 432 in 549f360

deallocate (field_2d)

GENBE_2.0/src/gen_be_stage4.F

Line 433 in 549f360

deallocate (cov)

GENBE_2.0/src/gen_be_stage4.F

Line 434 in 549f360

deallocate (cor)

GENBE_2.0/src/gen_be_stage4.F

Line 435 in 549f360

deallocate (mean)

GENBE_2.0/src/gen_be_stage4.F

Line 436 in 549f360

deallocate (var)

2. cov is passed directly to get_covariance_masked rather than passing as cov(b, :). It is not clear what the effect would be

Also, ls_method = 1 appears to only work with single level variables. Is this as intended?

I am pursuing ls_method = 1 instead of 2 because I am getting surprising results and wanted to explore other options.