Add `core release` command #109

schlessera · 2019-04-11T12:45:53Z

Adds retrieval of available releases from the wordpress.org API server.

Version constraints are interpreted in the following way right now:

4 => anything that starts with the major version 4. This would mean >= 4.0.0 && < 5.0.0.
4.8 => anything that starts with the major version 4 and minor version 8. This would mean >= 4.8.0 && < 4.9.0

Some notes:

Patch, pre-release or build constraints are not supported yet, as the API server does not provide querying functionality for these.
I initially added a --locale flag, but removed it again for now, as the API server does not seem to respect it for all results, only for the very latest version.

Fixes #108

Abstract `wp core verify-checksums` to wp-cli/checksum-command

Run Travis tests against WP-CLI dev-master

Update tests for WP 4.7.4

Fix Travis CI caching for composer

Update tests for WP 4.7.5

For PHP 7.1 compat use get_wp_details() instead of "version.php" include.

Use {WP_VERSION-latest} vars to avoid needing to update tests on WP releases.

Clarify this command as a bundled command

Replace instances of `wp.dev` with `example.com`

Implement CS checking based on the `WP_CLI_CS` ruleset

Co-Authored-By: wojsmol <[email protected]>

Change `CoreUpgrader::download_package` signature

Enhancement: Add PHP 7.3 to Travis CI build matrix

Lock framework version to ^2.2

thrijith

@schlessera Can you please merge latest master here, for CS changes?

Skip additional tests on php 5.4

chesio · 2019-08-26T08:27:30Z

I would suggest to update example output to include WordPress 5.2 release as well - with an actual change in required PHP version it would make the examples even more telling.

thrijith

Only minor query, rest LGTM.

thrijith · 2019-10-02T03:47:09Z

src/Core_Command.php

+		$response = Utils\http_request( 'GET', $url );
+
+		if ( strncmp( (string) $response->status_code, '2', 1 ) ) {
+			WP_CLI::error(


Could we avoid usage of sprintf?

thrijith · 2019-10-02T04:05:07Z

src/Core_Command.php

+		$semver_regex = '/^v?(\d+)(?:\.(\d+))?(?:\.(\d+))?(?:-([0-9A-Z-.]+))?(?:\+([0-9A-Z-.]+)?)?$/i';
+
+		if ( ! preg_match( $semver_regex, $version, $matches ) ) {
+			WP_CLI::error(


Same as above.

thrijith · 2019-10-02T04:14:11Z

Also as @chesio mentioned, an example of 5.2 would be a good.

nylen · 2019-10-15T04:28:27Z

Shouldn't this be called releases instead?

schlessera · 2019-10-15T06:05:46Z

Shouldn't this be called releases instead?

I think the "resource" we're dealing with here is "a release", and you can fetch a list of multiples of this resource. Just as we have plugin, post or option as singular resource names.

For context, the main use case I have for this is to turn a generic "release to use for tests" into "the latest release matching this criteria to use for tests".

So, if I state that I want to run tests with 4.9, I don't want to fetch 4.9.0, but rather the latest bugfix release of the 4.9 branch.
(see wp-cli/wp-cli-tests#51)

schlessera · 2019-10-15T06:08:34Z

BTW, this is still unmerged because the endpoint I'm using doesn't provide everything I need and I'm not sure I'm using the correct endpoint in the first place (see #108 for more details).

nylen · 2019-10-15T14:22:51Z

I think the "resource" we're dealing with here is "a release", and you can fetch a list of multiples of this resource. Just as we have plugin, post or option as singular resource names.

I'm not sure the same principle applies - all the other examples have multiple subcommands, and in that case it should be wp core release list.

When I read core release I thought of release as a verb, and thought: "Why would someone use WP-CLI to do a core release?"

nylen · 2019-10-15T18:47:48Z

For context, the main use case I have for this is to turn a generic "release to use for tests" into "the latest release matching this criteria to use for tests".

It seems like there are 2 uses cases then: listing all releases (optionally matching some criteria), or finding the latest release (optionally matching some criteria).

Tying back into the "resource" discussion, why not make this into a proper resource with appropriate subcommands for these cases? For example:

wp release list
wp release list --version=4.9
wp release latest
wp release latest --version=4.9

Using --version as a partial match also seems a bit off, since a version should point to a specific release. Maybe this should be --branch or --series instead?

danielbachhuber · 2022-11-18T15:32:57Z

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/c3f452c41ae22532df1123550fec5f84 in case this PR is auto-closed or broken in some way.

danielbachhuber and others added 30 commits April 18, 2017 05:04

Remove test file now tracked in package repository

1cd2984

Merge pull request #4005 from wp-cli/3728-checksum-command

37095c2

Abstract `wp core verify-checksums` to wp-cli/checksum-command

Remove files unrelated to wp core *

6d51298

Use PSR-4 autoloading of existing classes; add remaining test files

e50ffcc

Run tests against dev branch

6cc4f56

Update description to be more specific

4ba6d60

Run tests with the test script

e2ec7ea

Run Travis tests against WP-CLI dev-master

c5a555e

Merge pull request #2 from wp-cli/danielbachhuber-patch-1

afa2af0

Run Travis tests against WP-CLI dev-master

Update tests for WP 4.7.4

9c6ad5c

Fix Travis CI caching for composer

3626255

Merge pull request #3 from wp-cli/bump-wp-4-7-4

82ba04a

Update tests for WP 4.7.4

Merge pull request #5 from ntwb/patch-1

39ec09c

Fix Travis CI caching for composer

Update tests for WP 4.7.5

8be6337

Fix version number

32c1989

Merge pull request #7 from wp-cli/bump-wp-4-7-5

8b0f734

Update tests for WP 4.7.5

Add {WP_VERS[ver]} variable processing for behat.

eceacf4

Remove require-wp-4.0 tag.

62e050c

Use api.wordpress.org.

997ec67

User {WP_VERSION-ver-latest} syntax.

2435a89

For PHP 7.1 compat use get_wp_details() instead of version.php include.

d686a6f

Exclude PHP 7.0 from WP 3.7 test also.

5139ffe

Merge pull request #13 from gitlost/php7.1_compat

d1e0beb

For PHP 7.1 compat use get_wp_details() instead of "version.php" include.

Merge upstream & adjust.

3879ca1

Add latest_version command; allow vars in version check.

1b8fae3

Fix latest_version doc, unnecessary check.

b437a05

Just do {WP_VERSION-latest} variables in this branch.

d64e586

Merge pull request #15 from gitlost/version

2822bb1

Use {WP_VERSION-latest} vars to avoid needing to update tests on WP releases.

Clarify this command as a bundled command

24f0ecb

Merge pull request #16 from wp-cli/clarify-bundled

22e0caa

Clarify this command as a bundled command

schlessera and others added 13 commits April 23, 2019 17:30

Merge pull request #115 from luc122c/patch-1

8821525

Replace instances of `wp.dev` with `example.com`

Merge branch 'master' into use-wp-cli-cs

bb0f401

Simplify email filter

fe32722

Switch to latest framework to test whether that fixes Travis

2b1e589

Merge pull request #117 from wojsmol/use-wp-cli-cs

1dc9699

Implement CS checking based on the `WP_CLI_CS` ruleset

Change CoreUpgrader::download_package signature

e84ed54

Update src/WP_CLI/Core/CoreUpgrader.php

02d014a

Co-Authored-By: wojsmol <[email protected]>

Merge pull request #120 from wojsmol/chenge-signature

e19b89c

Change `CoreUpgrader::download_package` signature

Skip downgrading test for PHP 7.3+

84d683d

Skip unlocalized release test on PHP 7.3+ for now

dd4fafc

Merge pull request #111 from localheinz/feature/php73

0b5c60d

Enhancement: Add PHP 7.3 to Travis CI build matrix

Lock framework version to ^2.2

39dd73c

Merge pull request #121 from wp-cli/lock-framework-version-to-220

1463482

Lock framework version to ^2.2

thrijith reviewed Apr 28, 2019

View reviewed changes

wojsmol and others added 5 commits June 4, 2019 16:38

Skip additional tests on php 5.4

4bc1535

fix

88ed6c9

Skip additional tests on php 5.4 (#127)

f8b5797

Skip additional tests on php 5.4

Merge branch 'master' into 108-add-core-release-command

6f0410b

Fix PHPCS issues

0e32c85

thrijith suggested changes Oct 2, 2019

View reviewed changes

danielbachhuber closed this Nov 18, 2022

danielbachhuber force-pushed the master branch from d289b58 to 762c7ce Compare November 18, 2022 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `core release` command #109

Add `core release` command #109

schlessera commented Apr 11, 2019

thrijith left a comment

chesio commented Aug 26, 2019

thrijith left a comment

thrijith Oct 2, 2019

thrijith Oct 2, 2019

thrijith commented Oct 2, 2019

nylen commented Oct 15, 2019

schlessera commented Oct 15, 2019

schlessera commented Oct 15, 2019

nylen commented Oct 15, 2019

nylen commented Oct 15, 2019

danielbachhuber commented Nov 18, 2022

Add core release command #109

Add core release command #109

Conversation

schlessera commented Apr 11, 2019

thrijith left a comment

Choose a reason for hiding this comment

chesio commented Aug 26, 2019

thrijith left a comment

Choose a reason for hiding this comment

thrijith Oct 2, 2019

Choose a reason for hiding this comment

thrijith Oct 2, 2019

Choose a reason for hiding this comment

thrijith commented Oct 2, 2019

nylen commented Oct 15, 2019

schlessera commented Oct 15, 2019

schlessera commented Oct 15, 2019

nylen commented Oct 15, 2019

nylen commented Oct 15, 2019

danielbachhuber commented Nov 18, 2022

Add `core release` command #109

Add `core release` command #109